[llvm-commits] [llvm] r173663 - Cleaned up includes in various ObjCARC files and removed some whitespace violations.

[Michael Gottesman]

Technically I could remove it, it is true. But I feel like I should include it to show where the declaration is.

On Jan 27, 2013, at 9:57 PM, Michael Gottesman <mgottesman at apple.com> wrote:

> The reason why the c interface is included is for the declaration of the function LLVMInitializeObjCARCOpts. I put said function in specifically since the ObjCARC optimizations would be initialized as apart of LLVMInitializeScalarOpts. If someone uses the c-interface and was depending on ObjCARCOpts through ScalarOpts we should provide them a way to do such a thing.
> 
> On Jan 27, 2013, at 9:54 PM, Bill Wendling <wendling at apple.com> wrote:
> 
>> On Jan 27, 2013, at 9:51 PM, Michael Gottesman <mgottesman at apple.com> wrote:
>> 
>>> Author: mgottesman
>>> Date: Sun Jan 27 23:51:58 2013
>>> New Revision: 173663
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=173663&view=rev
>>> Log:
>>> Cleaned up includes in various ObjCARC files and removed some whitespace violations.
>>> 
>>> Modified:
>>>  llvm/trunk/lib/Transforms/ObjCARC/ObjCARC.cpp
>>>  llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp
>>>  llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAliasAnalysis.cpp
>>>  llvm/trunk/lib/Transforms/ObjCARC/ObjCARCExpand.cpp
>>> 
>>> Modified: llvm/trunk/lib/Transforms/ObjCARC/ObjCARC.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/ObjCARC.cpp?rev=173663&r1=173662&r2=173663&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/Transforms/ObjCARC/ObjCARC.cpp (original)
>>> +++ llvm/trunk/lib/Transforms/ObjCARC/ObjCARC.cpp Sun Jan 27 23:51:58 2013
>>> @@ -14,15 +14,14 @@
>>> //===----------------------------------------------------------------------===//
>>> 
>>> #include "ObjCARC.h"
>>> -
>>> -#include "llvm-c/Initialization.h"
>>> -#include "llvm/Analysis/Passes.h"
>>> -#include "llvm/Analysis/Verifier.h"
>>> -#include "llvm/IR/DataLayout.h"
>>> +#include "llvm-c/Core.h"
>> 
>> Are you really using the C interface? That doesn't sound right...
>> 
>> -bw
>> 
>>> #include "llvm/InitializePasses.h"
>>> -#include "llvm/PassManager.h"
>>> #include "llvm/Support/CommandLine.h"
>>> 
>>> +namespace llvm {
>>> +  class PassRegistry;
>>> +}
>>> +
>>> using namespace llvm;
>>> using namespace llvm::objcarc;
>>> 
>>> 
>>> Modified: llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp?rev=173663&r1=173662&r2=173663&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp (original)
>>> +++ llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAPElim.cpp Sun Jan 27 23:51:58 2013
>>> @@ -176,4 +176,3 @@ bool ObjCARCAPElim::runOnModule(Module &
>>> 
>>> return Changed;
>>> }
>>> -
>>> 
>>> Modified: llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAliasAnalysis.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAliasAnalysis.cpp?rev=173663&r1=173662&r2=173663&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAliasAnalysis.cpp (original)
>>> +++ llvm/trunk/lib/Transforms/ObjCARC/ObjCARCAliasAnalysis.cpp Sun Jan 27 23:51:58 2013
>>> @@ -21,8 +21,18 @@
>>> //===----------------------------------------------------------------------===//
>>> 
>>> #define DEBUG_TYPE "objc-arc-aa"
>>> +
>>> #include "ObjCARC.h"
>>> #include "ObjCARCAliasAnalysis.h"
>>> +#include "llvm/IR/Instruction.h"
>>> +#include "llvm/InitializePasses.h"
>>> +#include "llvm/PassAnalysisSupport.h"
>>> +#include "llvm/PassSupport.h"
>>> +
>>> +namespace llvm {
>>> +  class Function;
>>> +  class Value;
>>> +}
>>> 
>>> #include "llvm/IR/Instruction.h"
>>> #include "llvm/InitializePasses.h"
>>> @@ -161,4 +171,3 @@ ObjCARCAliasAnalysis::getModRefInfo(Immu
>>> // and OnlyAccessesArgumentPointees calls or other well-behaved calls.
>>> return AliasAnalysis::getModRefInfo(CS1, CS2);
>>> }
>>> -
>>> 
>>> Modified: llvm/trunk/lib/Transforms/ObjCARC/ObjCARCExpand.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/ObjCARCExpand.cpp?rev=173663&r1=173662&r2=173663&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/Transforms/ObjCARC/ObjCARCExpand.cpp (original)
>>> +++ llvm/trunk/lib/Transforms/ObjCARC/ObjCARCExpand.cpp Sun Jan 27 23:51:58 2013
>>> @@ -24,8 +24,27 @@
>>> //===----------------------------------------------------------------------===//
>>> 
>>> #define DEBUG_TYPE "objc-arc-expand"
>>> +
>>> #include "ObjCARC.h"
>>> 
>>> +#include "llvm/ADT/StringRef.h"
>>> +#include "llvm/IR/Function.h"
>>> +#include "llvm/IR/Instruction.h"
>>> +#include "llvm/IR/Instructions.h"
>>> +#include "llvm/IR/Value.h"
>>> +#include "llvm/Pass.h"
>>> +#include "llvm/PassAnalysisSupport.h"
>>> +#include "llvm/PassRegistry.h"
>>> +#include "llvm/PassSupport.h"
>>> +#include "llvm/Support/Casting.h"
>>> +#include "llvm/Support/Debug.h"
>>> +#include "llvm/Support/InstIterator.h"
>>> +#include "llvm/Support/raw_ostream.h"
>>> +
>>> +namespace llvm {
>>> +  class Module;
>>> +}
>>> +
>>> using namespace llvm;
>>> using namespace llvm::objcarc;
>>> 
>>> @@ -108,4 +127,3 @@ bool ObjCARCExpand::runOnFunction(Functi
>>> 
>>> return Changed;
>>> }
>>> -
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits