[llvm-commits] [PATCH] Extract ObjCARC into its own library to facilitate refactoring.

[Michael Gottesman]

(i.e. I agree and am going to do that).

On Jan 27, 2013, at 2:11 AM, Michael Gottesman <mgottesman at apple.com> wrote:

> I was actually thinking the same thing earlier this evening Bill. (you read my mind). 
> 
> On Jan 27, 2013, at 2:02 AM, Bill Wendling <wendling at apple.com> wrote:
> 
>> I don't have a problem with splitting the file up into its own library (I think it's a good idea). I did have a question of whether it would be better to put it in its own directory (like the InstCombine stuff) instead of making it a subdirectory of Transforms/Scalar.
>> 
>> Thoughts?
>> 
>> -bw
>> 
>> On Jan 26, 2013, at 10:38 PM, Chandler Carruth <chandlerc at google.com> wrote:
>> 
>>> Looks good with one more fix:
>>> 
>>> It should have it's own header file, much like we have include/llvm/Transforms/Scalar.h and the declarations of the free functions should be moved from Scalar.h to its new header. The Scalar.h include should also be replaced.
>>> 
>>> Feel free to submit once you've made that fixe
>>> 
>>> 
>>> On Sat, Jan 26, 2013 at 4:53 PM, Michael Gottesman <mgottesman at apple.com> wrote:
>>> The following patch extracts ObjCARC into its own library. This is because I am going to in the near future start refactoring its multiple passes into separate files. This implies that it must be its own library since it will have multiple source files (if my understanding of the LLVM library criteria is correct).
>>> 
>>> I have successfully built llvm/clang with my changes on Darwin with both cmake/ninja and autoconf/make.
>>> 
>>> Please Review,
>>> 
>>> Michael
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits