[llvm-commits] [PATCH] Extract ObjCARC into its own library to facilitate refactoring.

Chandler Carruth chandlerc at google.com
Sat Jan 26 22:38:33 PST 2013


Looks good with one more fix:

It should have it's own header file, much like we have
include/llvm/Transforms/Scalar.h and the declarations of the free functions
should be moved from Scalar.h to its new header. The Scalar.h include
should also be replaced.

Feel free to submit once you've made that fixe


On Sat, Jan 26, 2013 at 4:53 PM, Michael Gottesman <mgottesman at apple.com>wrote:

> The following patch extracts ObjCARC into its own library. This is because
> I am going to in the near future start refactoring its multiple passes into
> separate files. This implies that it must be its own library since it will
> have multiple source files (if my understanding of the LLVM library
> criteria is correct).
>
> I have successfully built llvm/clang with my changes on Darwin with both
> cmake/ninja and autoconf/make.
>
> Please Review,
>
> Michael
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130126/f36bf9a3/attachment.html>


More information about the llvm-commits mailing list