[llvm-commits] [lld] r173570 - Use proper delete.
Michael J. Spencer
bigcheesegs at gmail.com
Sat Jan 26 04:26:56 PST 2013
Author: mspencer
Date: Sat Jan 26 06:26:56 2013
New Revision: 173570
URL: http://llvm.org/viewvc/llvm-project?rev=173570&view=rev
Log:
Use proper delete.
Modified:
lld/trunk/lib/ReaderWriter/Native/ReaderNative.cpp
lld/trunk/lib/ReaderWriter/YAML/ReaderWriterYAML.cpp
Modified: lld/trunk/lib/ReaderWriter/Native/ReaderNative.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/Native/ReaderNative.cpp?rev=173570&r1=173569&r2=173570&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/Native/ReaderNative.cpp (original)
+++ lld/trunk/lib/ReaderWriter/Native/ReaderNative.cpp Sat Jan 26 06:26:56 2013
@@ -360,7 +360,7 @@ public:
delete _sharedLibraryAtoms._arrayStart;
delete _absoluteAtoms._arrayStart;
delete _references.arrayStart;
- delete _targetsTable;
+ delete [] _targetsTable;
}
virtual const atom_collection<DefinedAtom>& defined() const {
Modified: lld/trunk/lib/ReaderWriter/YAML/ReaderWriterYAML.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/YAML/ReaderWriterYAML.cpp?rev=173570&r1=173569&r2=173570&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/YAML/ReaderWriterYAML.cpp (original)
+++ lld/trunk/lib/ReaderWriter/YAML/ReaderWriterYAML.cpp Sat Jan 26 06:26:56 2013
@@ -167,7 +167,7 @@ private:
// We want _stringCopies to own the string memory so it is deallocated
// when the File object is destroyed. But we need a StringRef that
// points into that memory.
- std::unique_ptr<char> s = std::unique_ptr<char>(new char[str.size()]);
+ std::unique_ptr<char[]> s(new char[str.size()]);
memcpy(s.get(), str.data(), str.size());
llvm::StringRef r = llvm::StringRef(s.get(), str.size());
_stringCopies.push_back(std::move(s));
@@ -178,7 +178,7 @@ private:
unsigned int _unnamedCounter;
NameToAtom _nameMap;
AtomToRefName _refNames;
- std::vector<std::unique_ptr<char>> _stringCopies;
+ std::vector<std::unique_ptr<char[]>> _stringCopies;
};
@@ -706,7 +706,7 @@ struct MappingTraits<const lld::File*> {
// We want _stringCopies to own the string memory so it is deallocated
// when the File object is destroyed. But we need a StringRef that
// points into that memory.
- std::unique_ptr<char> s = std::unique_ptr<char>(new char[str.size()]);
+ std::unique_ptr<char[]> s(new char[str.size()]);
memcpy(s.get(), str.data(), str.size());
llvm::StringRef r = llvm::StringRef(s.get(), str.size());
_stringCopies.push_back(std::move(s));
@@ -720,7 +720,7 @@ struct MappingTraits<const lld::File*> {
AtomList<lld::UndefinedAtom> _undefinedAtoms;
AtomList<lld::SharedLibraryAtom> _sharedLibraryAtoms;
AtomList<lld::AbsoluteAtom> _absoluteAtoms;
- std::vector<std::unique_ptr<char>> _stringCopies;
+ std::vector<std::unique_ptr<char[]>> _stringCopies;
};
More information about the llvm-commits
mailing list