[llvm-commits] [llvm] r173454 - /llvm/trunk/lib/IR/Attributes.cpp

[David Blaikie]

Might be worth filing a bug on clang to consider adding a such a warning?
On Jan 25, 2013 7:38 AM, "Reid Kleckner" <reid at kleckner.net> wrote:

> Author: rnk
> Date: Fri Jan 25 09:35:56 2013
> New Revision: 173454
>
> URL: http://llvm.org/viewvc/llvm-project?rev=173454&view=rev
> Log:
> Fix MSVC 2012 warning about a 32-bit shift that should be 64-bit
>
> Modified:
>     llvm/trunk/lib/IR/Attributes.cpp
>
> Modified: llvm/trunk/lib/IR/Attributes.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Attributes.cpp?rev=173454&r1=173453&r2=173454&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/IR/Attributes.cpp (original)
> +++ llvm/trunk/lib/IR/Attributes.cpp Fri Jan 25 09:35:56 2013
> @@ -524,12 +524,12 @@
>
>  uint64_t AttributeImpl::getAlignment() const {
>    uint64_t Mask = Raw() & getAttrMask(Attribute::Alignment);
> -  return 1U << ((Mask >> 16) - 1);
> +  return 1ULL << ((Mask >> 16) - 1);
>  }
>
>  uint64_t AttributeImpl::getStackAlignment() const {
>    uint64_t Mask = Raw() & getAttrMask(Attribute::StackAlignment);
> -  return 1U << ((Mask >> 26) - 1);
> +  return 1ULL << ((Mask >> 26) - 1);
>  }
>
>  void AttributeImpl::Profile(FoldingSetNodeID &ID, Constant *Data,
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130125/bfbbb754/attachment.html>