[llvm-commits] [PATCH]: POC patch for specifying which sections to dump in llvm-dwarfdump

[Eric Christopher]

Pretty good with the basic idea, few comments:

-  OwningPtr<DIContext> dictx(DIContext::getDWARFContext(Obj.get()));
+  OwningPtr<DIContext> DICtx(DIContext::getDWARFContext(Obj.get()));

Seems somewhat gratuitous.

+void DWARFContext::dump(raw_ostream &OS, DIDumpType DumpType) {

I'd kind of like this to have DumpType with a default arg of all.

For a list of options I'd take start with one per section name (including
the dwo sections).

Needs tests.

Thanks!

-eric


On Thu, Jan 24, 2013 at 3:19 PM, Eli Bendersky <eliben at google.com> wrote:

> Hi,
>
> [Eric: we discussed the background on IRS. Here for completeness].
>
> I plan to add some additional dumping options to llvm-dwarfdump. As
> part of the preparation work, I'd like to be able to specify which
> sections it should dump (at the moment all sections are dumped).
>
> The attached patch is a proof-of-concept just to demonstrate the
> direction. The default behavior remains what it was, but now a couple
> of sections can be selected specifically with a flag. If this seems
> reasonable, I'll go ahead and expand it for all currently supported
> options prior to committing it.
>
> PTAL,
>
> Eli
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130124/d7b2758b/attachment.html>