[llvm-commits] [PATCH] Delay handling symbol aliases when writing COFF (fixes PR14447)

Michael Spencer bigcheesegs at gmail.com
Thu Jan 24 14:12:29 PST 2013


On Thu, Jan 24, 2013 at 1:46 PM, Nico Rieck <nico.rieck at gmail.com> wrote:
> This supports aliasing chains where the assignments are specified out of
> order, e.g.
>
>     .globl _alias2
> _alias2 = _alias1
>     .globl _alias1
> _alias1 = _foo
>
> Previously, this resulted in _alias2 being undefined.
>
> Because the symbol data is identical save for the symbol name,
> DefineSymbol() receives the symbol as additional parameter. This allows
> passing in the aliased name with the original symbol data.
>
> This fixes PR14447 (not using -cxx-abi microsoft, which seems to be
> broken).
>
>
> -Nico

LGTM. Thanks!

- Michael Spencer



More information about the llvm-commits mailing list