[llvm-commits] [PATCH] review for MC ELF header e_flags setting

Carter, Jack jcarter at mips.com
Thu Jan 24 13:41:49 PST 2013


This is not a rehash of an old patch.

Currently gathering information such as symbol, section and data is done by collecting it in an MCAssembler object. From MCAssembler and MCAsmLayout objects ELFObjectWriter::WriteObject() forms and streams out the ELF object file.

This patch just adds a few members to the MCAssember class to store and access the e_flag settings. It allows for runtime additions to the e_flag by assembler directives. The standalone assembler can get to MCAssembler from getParser().getStreamer().getAssembler().

The downside is that I am putting an ELF specific data member in MCAssembler (right next to an existing MACH specific member). We probably should have an MCELFAssembler object down the road.

I have looked at the ARMELFStreamer files and I do not see how they apply to the e_flag bit field data storage.

Please review and comment.

Regards,

Jack
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130124/162b55e0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eheader4.patch
Type: text/x-patch
Size: 8522 bytes
Desc: eheader4.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130124/162b55e0/attachment.bin>


More information about the llvm-commits mailing list