[llvm-commits] [PATCH] [lld][ELF] Add very basic support for IFUNC.

Michael Spencer bigcheesegs at gmail.com
Thu Jan 24 12:06:19 PST 2013



================
Comment at: lib/ReaderWriter/ELF/ELFTargetInfo.cpp:65-66
@@ -58,1 +64,4 @@
 
+class GOTAtom : public SimpleDefinedAtom {
+  static const uint8_t _defaultContent[8];
+
----------------
Shankar Kalpathi Easwaran wrote:
> Michael Spencer wrote:
> > Shankar Kalpathi Easwaran wrote:
> > > shouldnt this be a ELFDefinedAtom ?
> > Why? The Writer is only going to see it as a DefinedAtom.
> Oh Yeah, got your point, but since you are going to add ELF type references to the Atom, I thought it would make better sense to have it as ELFDefinedAtom. Also how are you keeping the symbol information, that you have created a GOT entry or that symbol ?
The problem with ELFDefinedAtom is that I would need an ELFType and all the dispatching associated with that.

Currently not tracking which symbol info. Currently this would generate a stub for every access.


http://llvm-reviews.chandlerc.com/D324



More information about the llvm-commits mailing list