[llvm-commits] More aggressive speculation in SimplifyCFG

[Krzysztof Parzyszek]

On 1/23/2013 9:41 PM, Hal Finkel wrote:
>
>
> -; RUN: opt < %s -simplifycfg -S | FileCheck %s
> +; RUN: opt < %s -simplifycfg -new-gen-sel=false -S | FileCheck %s
>
> Several tests have this change. Why? (false is the default).

Because if someone ran these tests with this option enabled by default, 
they would fail.  This will force it off.  The CHECKs for selects only 
are like that because depending on whether this option is on or off, the 
order of generated selects changes in some cases (the thecases are 
optimized in different ways, leading to similar, but not identical 
outputs), or the selects are generated by different parts on 
SimplifyCFG, leading to different value names being used.  In the 
testcase I wrote I simply wanted to follow the suit.

I can make the changes you mentioned---no problem.  I expected that 
there would be comments on this code anyways, so I wanted to get some 
initial feedback before making too many changes up front.

-Krzysztof

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation