[llvm-commits] [PATCH] Adding x32 ABI triple and separate StackSlotSize in MCAsmInfo

[Evan Cheng]

On Jan 22, 2013, at 2:35 PM, Eli Bendersky <eliben at google.com> wrote:

>>> 
>>> Evan, I'm not sure what you're referring to here. Could you please clarify?
>> 
>> CalleeSaveStackSlotSize now has special meaning when it is zero, perhaps something like CalleeSaveStackSlotSizeOverride is more appropriate? I personally really don't like this, I think it optimizing for out-of-tree targets is not the right approach. It's making the code harder to understand.
>> 
> 
> I'm fine with reverting to the originally proposed approach of simply
> setting this value in the target MCAsmInfo constructors and losing the
> "if 0 then use default" behavior.

That would be my preference but I'm certainly not trying to dictate it. It's your call.

Evan

> 
> Eli