[llvm-commits] Tablgen bugfix

Malul, Elior elior.malul at intel.com
Mon Jan 21 23:12:19 PST 2013


Yes it is, in fact the logics in this line has not been changed. (I just replaced the hard-coded '80' with MAX_LINE_LEN).
Thx, Elior

-----Original Message-----
From: dag at cray.com [mailto:dag at cray.com] 
Sent: Monday, January 21, 2013 22:31
To: Malul, Elior
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] Tablgen bugfix

"Malul, Elior" <elior.malul at intel.com> writes:

> Attached it a fix to the function, which when it encounters a 
> description string longer than 80 character, it splits to several 
> lines.  I will appreciate if those who care about tblgen will review 
> it.

> +  for (unsigned i = OS.tell() - Pos, e = MAX_LINE_LEN - 
> + Suffix.size(); i < e; ++i)

Is this still within the 80 column limit?

Otherwise, LGTM.

                          -David
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.





More information about the llvm-commits mailing list