[llvm-commits] [llvm] r173010 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

[dag at cray.com]

Craig Topper <craig.topper at gmail.com> writes:

> This change was very specific to the loop that the code is using. While its
> in shuffle code its not looking at the shuffle indices. It's just checking
> to see if the 128-bit lanes are linked using a variable that's specific to
> this loop. The value is either -1(not linked) or a positive value(linked).

Is there commentary here explaining this?  This kind of thing gets very
confusing very quickly.

I don't like magic constants.  Better to use a const int or a helper
predicate function.

                           -David