[llvm-commits] [llvm] r173010 - /llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

dag at cray.com dag at cray.com
Mon Jan 21 12:22:29 PST 2013


Craig Topper <craig.topper at gmail.com> writes:

> Author: ctopper
> Date: Mon Jan 21 01:25:16 2013
> New Revision: 173010
>
> URL: http://llvm.org/viewvc/llvm-project?rev=173010&view=rev
> Log:
> Use <0 checks in place of ==-1 because it results in simpler code.

Is that perhaps obscuring the intent?  -1 is a special UNDEF value.  I
preferred the old code where we had an isUNDEF helper.

                                    -David



More information about the llvm-commits mailing list