[llvm-commits] [PATCH] [test-suite] smallpt single source benchmark

[Redmond, Paul]

Committed in r173059.

Thanks!

On 2013-01-20, at 9:25 PM, Alastair Murray wrote:

> Hi Paul, all,
> 
> Trivial patch to the SmallPT benchmark Makefile is attached.  It adds -lstdc++ to LDFLAGS.
> 
> This isn't required for TEST=simple as clang++ is used directly. TEST=profile, however, uses intermediate steps and then links (i.e. no implicit -lstdc++).  Possibly other tests as well.
> 
> I don't have commit access so if you agree with the change please apply it.
> 
> Regards,
> Alastair.
> 
> On 07/01/13 10:28, Redmond, Paul wrote:
>> Added in r171745.
>> 
>> On 2013-01-05, at 2:54 PM, Evan Cheng wrote:
>> 
>>> Yes please do. I'm even more interested in fixing this!
>>> 
>>> Thanks,
>>> 
>>> Evan
>>> 
>>> On Dec 20, 2012, at 8:01 AM, "Redmond, Paul" <paul.redmond at intel.com> wrote:
>>> 
>>>> Hi,
>>>> 
>>>> Attached is a patch that adds the smallpt benchmark (http://www.kevinbeason.com/smallpt/) to the test-suite. There's lots of room for improvement given these numbers:
>>>> 
>>>> $ g++ -o smallpt-gcc smallpt.cpp -O3
>>>> $ ./smallpt-gcc
>>>> Rendering (4 spp)
>>>> 
>>>> real 0m5.658s
>>>> user 0m5.632s
>>>> sys 0m0.008s
>>>> 
>>>> $ icc -o smallpt-icc smallpt.cpp -O3
>>>> $ time ./smallpt-icc
>>>> Rendering (4 spp)
>>>> 
>>>> real 0m4.570s
>>>> user 0m4.544s
>>>> sys 0m0.012s
>>>> 
>>>> $ clang++ -o smallpt-clang smallpt.cpp -O3
>>>> $ time ./smallpt-clang
>>>> Rendering (4 spp)
>>>> 
>>>> real 0m6.513s
>>>> user 0m6.488s
>>>> sys 0m0.004s
>>>> 
>>>> An obvious improvement is that both ICC and GCC transforms sin and cos into sincos while LLVM does not.
>>>> 
>>>> Should I add this benchmark to the test-suite?
>>>> 
>>>> paul
>>>> 
>>>> <smallpt.diff>_______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> 
> <smallpt_link.patch>