[llvm-commits] [compiler-rt] r173021 - in /compiler-rt/trunk/lib/asan: asan_intercepted_functions.h asan_mapping.h tests/CMakeLists.txt tests/asan_noinst_test.cc

[Alexey Samsonov]

On Mon, Jan 21, 2013 at 3:22 PM, Kostya Serebryany <kcc at google.com> wrote:

> Also, I think we should be building the majority of the tests in the
> default mode.
> And for lit-tests we should run both modes.
>
> --kcc
>
>
> On Mon, Jan 21, 2013 at 3:13 PM, Kostya Serebryany <kcc at google.com> wrote:
>
>>
>> On Mon, Jan 21, 2013 at 2:51 PM, Alexey Samsonov <samsonov at google.com>wrote:
>>
>>> +  // In zero-based shadow mode we treat addresses near zero as addresses
>>> +  // in shadow gap as well.
>>> +  if (ASAN_FLEXIBLE_MAPPING_AND_OFFSET)
>>>
>> Is this the right condition?
>>
>
Ah, indeed. Fixed in r173026 (and switched back to default mode in unit
tests).


>  +    return a <= kShadowGapEnd;
>>>    return a >= kShadowGapBeg && a <= kShadowGapEnd;
>>>
>>
>>
>>
>


-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130121/862ff3a5/attachment.html>