[llvm-commits] [compiler-rt] r172719 - in /compiler-rt/trunk/lib: asan/asan_intercepted_functions.h asan/asan_interceptors.cc sanitizer_common/sanitizer_common_interceptors.h sanitizer_common/sanitizer_platform_interceptors.h tsan/lit_tests/thread_name.cc tsan/rtl/tsan_interceptors.cc tsan/rtl/tsan_stat.cc tsan/rtl/tsan_stat.h

[Kostya Serebryany]

On Fri, Jan 18, 2013 at 10:31 AM, Kostya Serebryany <kcc at google.com> wrote:

>
>
>
> On Fri, Jan 18, 2013 at 2:55 AM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:
>
>>
>> On Jan 17, 2013, at 11:30 AM, Anna Zaks <ganna at apple.com> wrote:
>>
>> > Kostya,
>> >
>> > I am getting a makefile build failure (looks like it's caused by this
>> commit):
>> >
>> >  COMPILE:   clang_darwin/asan_osx_dynamic/x86_64:
>> /Volumes/Data/ws/llvmgit/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc
>> >
>> /Volumes/Data/ws/llvmgit/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc:78:13:
>> error: unused
>> >      function 'SetThreadName' [-Werror,-Wunused-function]
>> >
>> /Volumes/Data/ws/llvmgit/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc:78:13:
>> static void SetThreadName(const char *name) {
>> > error:             ^
>> > unused
>> >      function 'SetThreadName' [-Werror,-Wunused-function]
>> > static void SetThreadName(const char *name) {
>> >            ^
>> > 1 error generated.
>>
>> I reverted this patch along with the ones that depended on it to get the
>> buildbots going again.
>>
>> Kostya, go ahead and recommit once you've fixed the warning.
>>
>
> Sorry for the breakage and thanks for the revert!
>
>
>> BTW, in a project with that many #ifdefs, it is probably not a good idea
>> to build with -Werror.
>>
>
> Before the commits I build everything on linux with
>
> cmake -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON \
>  -DCMAKE_C_COMPILER=/home/kcc/host_clang/bin/clang \
>  -DCMAKE_CXX_COMPILER=/home/kcc/host_clang/bin/clang++ \
>  -DCMAKE_EXPORT_COMPILE_COMMANDS=ON /home/kcc/llvm/
>

Looks like -DLLVM_ENABLE_WERROR=ON should help.

--kcc



> make ...
>
> and then I rely on our (unfortunately internal) bots to catch regressions
> in the gcc build and on non-linux platforms.
>
> My fault, I did not notice this failure.
>
> --kcc
>
>
>
>
>>
>> Thanks,
>> /jakob
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130118/1422d3c2/attachment.html>