[llvm-commits] [compiler-rt] r172719 - in /compiler-rt/trunk/lib: asan/asan_intercepted_functions.h asan/asan_interceptors.cc sanitizer_common/sanitizer_common_interceptors.h sanitizer_common/sanitizer_platform_interceptors.h tsan/lit_tests/thread_name.cc tsan/rtl/tsan_interceptors.cc tsan/rtl/tsan_stat.cc tsan/rtl/tsan_stat.h

[Jakob Stoklund Olesen]

On Jan 17, 2013, at 11:30 AM, Anna Zaks <ganna at apple.com> wrote:

> Kostya,
> 
> I am getting a makefile build failure (looks like it's caused by this commit):
> 
>  COMPILE:   clang_darwin/asan_osx_dynamic/x86_64: /Volumes/Data/ws/llvmgit/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc
> /Volumes/Data/ws/llvmgit/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc:78:13: error: unused
>      function 'SetThreadName' [-Werror,-Wunused-function]
> /Volumes/Data/ws/llvmgit/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc:78:13: static void SetThreadName(const char *name) {
> error:             ^
> unused
>      function 'SetThreadName' [-Werror,-Wunused-function]
> static void SetThreadName(const char *name) {
>            ^
> 1 error generated.

I reverted this patch along with the ones that depended on it to get the buildbots going again.

Kostya, go ahead and recommit once you've fixed the warning.

BTW, in a project with that many #ifdefs, it is probably not a good idea to build with -Werror.

Thanks,
/jakob