[llvm-commits] [PATCH] Fix for PR 14652 and 14740

[Eli Friedman]

On Tue, Jan 15, 2013 at 2:51 PM, Akira Hatanaka <ahatanak at gmail.com> wrote:
>
> The attached patch is an attempt to fix the following bugs:
>
> http://llvm.org/bugs/show_bug.cgi?id=14652
> http://llvm.org/bugs/show_bug.cgi?id=14740
>
> It fixes the code which scalarizes vector shifts and ensures that the type
> of the shift amount operand is the type TargetLowering::getShiftAmountTy
> returns. This is the same approach taken in SelectionDAGBuilder::visitShift.
>
> The command that was failing in 14652 passes after this patch is applied
> and fixes 14740 as well.

The approach seems fine.  Can you factor out the logic into a utility function?

-Eli