[llvm-commits] Cost Table Draft

[Renato Golin Linaro]

Ok, final draft, I think the patch is good to go.

I now have reverted most of the C++-ish stuff and it's now more in line to
what it was before, though the types are merged, moved upwards and easier
to deal with.

I have reverted all previous tables to the new ones and have deleted the
old tables. I also moved the implementation to the cpp files, since no
templates were used.

Let me know if it's good to commit.

cheers,
--renato




On 16 January 2013 18:33, Renato Golin Linaro <renato.golin at linaro.org>wrote:

> On 16 January 2013 18:22, Benjamin Kramer <benny.kra at gmail.com> wrote:
>
>> thread-safety issues aside (I think most c++ implementation implement
>> some kind of safeguard for static initializers), the std::vectors in this
>> patch add static destructors to the code. We try to avoid those in LLVM,
>> can't you just keep them in static constant arrays and only wrap the search
>> on it with another object?
>>
>
> Hi Ben,
>
> That's a good point. I tried not to use vectors, but I'd have to use all
> sorts of tricks to keep variable length arrays without increasing in either
> template code or run time delays, though I haven't thought about the static
> destructors.
>
> I'll have another look. ;)
>
> cheers,
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130116/9909c2cb/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cost-table.patch
Type: application/octet-stream
Size: 12651 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130116/9909c2cb/attachment.obj>