[llvm-commits] [PATCH] A "very verbose" mode for FileCheck

[Dmitri Gribenko]

On Wed, Jan 16, 2013 at 9:47 PM, David Blaikie <dblaikie at gmail.com> wrote:
> On Wed, Jan 16, 2013 at 11:44 AM, Eli Bendersky <eliben at google.com> wrote:
>> On Wed, Jan 16, 2013 at 11:43 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>>> On Wed, Jan 16, 2013 at 9:39 PM, Eli Bendersky <eliben at google.com> wrote:
>>>> Yes, the effect of dumping a (sometimes largish) file on each
>>>> invocation of FileCheck should be measured, since we run thousands
>>>> upon thousands of instances of FileCheck for each "make check-all".
>>>
>>> It is done only on errors, so I don't think we care about performance
>>> impact (if any).
>
> How does this happen only on error? Is FileCheck already buffering the
> entire contents of the input anyway?
>
> Well, in any case, that's fine by me.

Not only buffers, but normalizes spaces.

> But leaves me with the question: why bother with the option to print
> to stderr at all? We can just improve the buildbot configuration to
> log these files alongside the failure log. (ensuring that they'll be
> complete/standalone/exact replicas of the input & you won't have to
> figure out where the file input begins/ends and the FileCheck/other
> log data is)

Because it is simpler?

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/