[llvm-commits] [llvm] r172630 - in /llvm/trunk: include/llvm/MC/MCContext.h lib/MC/MCDwarf.cpp test/MC/MachO/gen-dwarf-producer.s tools/llvm-mc/llvm-mc.cpp

[Eric Christopher]

On Wed, Jan 16, 2013 at 10:51 AM, Kevin Enderby <enderby at apple.com> wrote:

>
> On Jan 16, 2013, at 10:44 AM, Eric Christopher <echristo at gmail.com> wrote:
>
>
>
>
> On Wed, Jan 16, 2013 at 10:38 AM, David Blaikie <dblaikie at gmail.com>wrote:
>
>> On Wed, Jan 16, 2013 at 9:55 AM, Kevin Enderby <enderby at apple.com> wrote:
>> > Hi Eric,
>> >
>> > This is just for testing (without the clang change).  I didn't want to
>> add a
>> > it as a command line argument to llvm-mc as that would then have the
>> > producer string as it would also affect the AT_Apple flags.
>>
>> Curious: what do you mean by this? What are the AT_Apple flags?
>> (sorry, I'm not familiar with this area)
>>
>>
> There are some apple internal attributes on dwarf. They're usually tagged
> DW_AT_APPLE_...
>
>
>> As for the testing issue, could this be written as a unit test instead
>> of having a test hook like this? (Ideally even once Clang is testing
>> this code path, it'd be nice to still have LLVM functionality tested
>> in LLVM so LLVM developers who aren't necessarily working
>> with/building/testing Clang could still know that they haven't broken
>> this functionality - but I realize sometimes that benefit isn't worth
>> the overhead of writing such tests for relatively trivial features,
>> but it's worth checking* if we've reached a tipping point where a few
>> trivial features could all benefit from the addition of unit tests,
>> for example)
>>
>> * I say this in the absence of any specific knowledge - perhaps this
>> is the only such case & there's no aggregate benefit, etc, at the
>> moment.
>>
>>
> Not necessarily a bad idea. The code path could alternately be tested by a
> command line flag added to llvm-mc?
>
>
> Again I didn't want to add a command line to llvm-mc as it would effect
> the values in the DW_AT_APPLE since it contains all the command line.
>
>
> Hrm.  I wonder if the arguments to llvm-mc should be passed into
DW_AT_Apple_flags or if there should be a separate command line that adds
them in?

> Kevin? Your thoughts?
>
>
> I really don't care how this is tested.  I just want to get the work done.
>
>
*nod* I do have a baseline aversion to environment variables but I'm not
going to draw any lines in the sand. Just interested in getting the best
way of testing this in. :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130116/c780ee3a/attachment.html>