[llvm-commits] Cost Table Draft

[Benjamin Kramer]

On 16.01.2013, at 18:00, Renato Golin Linaro <renato.golin at linaro.org> wrote:

> Second version, with suggestions by David, and also making the builder static, too, or bad things could happen.

thread-safety issues aside (I think most c++ implementation implement some kind of safeguard for static initializers), the std::vectors in this patch add static destructors to the code. We try to avoid those in LLVM, can't you just keep them in static constant arrays and only wrap the search on it with another object?

- Ben

> cheers,
> --renato
> 
> 
> On 16 January 2013 15:35, Renato Golin Linaro <renato.golin at linaro.org> wrote:
> On 16 January 2013 15:33, David Tweed <David.Tweed at arm.com> wrote:
> The point I was making was more that you've got run-time checks that you can't call inappropriate methods which would not be needed if you had
> 
> 
> I got that, I was just referring why it was weird that way... ;) It's an evolving code...
> 
> --renato
> 
> <cost-table.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits