[llvm-commits] [llvm] r172156 - /llvm/trunk/include/llvm/Support/Compiler.h

[David Blaikie]

On Fri, Jan 11, 2013 at 12:47 PM, Joerg Sonnenberger
<joerg at britannica.bec.de> wrote:
> On Fri, Jan 11, 2013 at 02:46:05PM -0600, Krzysztof Parzyszek wrote:
>> On 1/11/2013 2:42 PM, Joerg Sonnenberger wrote:
>> >
>> >If __FUNCTION__ is supported, use that. Otherwise define it to
>> >"<unknown>".
>>
>> This is all fine, except that it doesn't explain your insistence on
>> redefining __func__.
>
> It avoids having to change all users for the sake of legacy compilers.

This is "all versions of MSVC", isn't it? That's not exactly "legacy compilers".

Generally we've done exactly as Krzystztof is doing when it comes to
cross-compiler differences. His approach seems reasonable/consistent
to me.

- David