[llvm-commits] [llvm] r172156 - /llvm/trunk/include/llvm/Support/Compiler.h

Joerg Sonnenberger joerg at britannica.bec.de
Fri Jan 11 12:34:39 PST 2013


On Fri, Jan 11, 2013 at 01:38:00PM -0600, Krzysztof Parzyszek wrote:
> On 1/11/2013 1:31 PM, Joerg Sonnenberger wrote:
> >
> >Again, what are you trying to do? If you want to emulate __func__ on
> >MSVC, just do the above. There is no reason to abstract this for the
> >sake of a single compiler. It is unnecessary churn.
> 
> "#define __xyx" is a Bad Idea for any xyz.
> 
> Once MSVC starts defining __func__, you may get a compiler error
> when you try to compile existing code.

So *test* for the presence before enabling it in config.h.

Joerg



More information about the llvm-commits mailing list