[llvm-commits] [llvm] r171866 - in /llvm/trunk: lib/CodeGen/AsmPrinter/AsmPrinter.cpp test/CodeGen/ARM/fp128.ll test/CodeGen/PowerPC/fp128.ll

[Tim Northover]

Thanks for the review.

> thanks for doing this, it looks great to me.  Do the existing testcases
> give complete code coverage (i.e. test the output for every floating point
> type

I think they have reasonable coverage (a couple of broken initial attempts 
caused failures), but it can't hurt to put them all in one place. I've added 
the extras.

> >    } else {
> >    
> >      unsigned Chunk;
> >      for (Chunk = 0; Chunk < NumBytes / sizeof(uint64_t); ++Chunk)
> 
> Can you get NumBytes / sizeof(uint64_t) from API.getNumWords() instead?

It's not quite the same thing: if TrailingBytes != 0 then they differ by 1. I 
tend to think "API.getNumWords() - (TrailingBytes != 0)" is even less clear.

I've committed it with the extra tests as r172189.

Tim.