[llvm-commits] [lld] support for adding absolute symbols in WriterELF

[Michael Spencer]

On Thu, Jan 10, 2013 at 10:38 PM, Sean Silva <silvas at purdue.edu> wrote:
> On Wed, Jan 9, 2013 at 2:42 PM, Shankar Easwaran
> <shankare at codeaurora.org> wrote:
>>> -RUN: lld -flavor ld -target x86_64-linux
>>> +# Will fail with unersolved symbol
>>> +RUN: lld -flavor ld -target x86_64-linux || exit 0
>>
>> This is a obscure test, I discussed with Michael on this, I think its just
>> testing the arguments.
>
> Hi Michael, Shankar:
>
> Could you explain the purpose of this test? The `|| exit 0` means that
> it can't possibly fail (even if lld segfaults or aborts, or the lld
> executable isn't present), so what is it supposed to test? This
> particular test appears to be causing some cargo culting in Shankar's
> latest patch, which introduces the analogous bizarre test for hexagon.
>
> -- Sean Silva

Previous lld would error if given a target that it couldn't create
both a driver and relocation handler for. This tested for that.
However, now passing no files breaks things.

This behavior is tested by other tests now, so this part of the test
can go away.

- Michael Spencer