[llvm-commits] [llvm] r172166 - /llvm/trunk/lib/MC/MCParser/AsmParser.cpp

NAKAMURA Takumi geek4civic at gmail.com
Thu Jan 10 18:50:09 PST 2013


Author: chapuni
Date: Thu Jan 10 20:50:09 2013
New Revision: 172166

URL: http://llvm.org/viewvc/llvm-project?rev=172166&view=rev
Log:
Revert r172153, "llvm/lib/MC/MCParser/AsmParser.cpp: [ms-inline-asm] Fix a couple of undefined behaviors. Operand->needAddressOf() is not initialized at !Operand->isReg()."

It has been redundant since r172157.

Modified:
    llvm/trunk/lib/MC/MCParser/AsmParser.cpp

Modified: llvm/trunk/lib/MC/MCParser/AsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCParser/AsmParser.cpp?rev=172166&r1=172165&r2=172166&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCParser/AsmParser.cpp (original)
+++ llvm/trunk/lib/MC/MCParser/AsmParser.cpp Thu Jan 10 20:50:09 2013
@@ -3934,8 +3934,7 @@
             std::string Constraint = "=";
             ++InputIdx;
             OutputDecls.push_back(OpDecl);
-            OutputDeclsAddressOf.push_back(Operand->isReg() &&
-                                           Operand->needAddressOf());
+            OutputDeclsAddressOf.push_back(Operand->needAddressOf());
             Constraint += Operand->getConstraint().str();
             OutputConstraints.push_back(Constraint);
             AsmStrRewrites.push_back(AsmRewrite(AOK_Output,
@@ -3943,8 +3942,7 @@
                                                 Operand->getNameLen()));
           } else {
             InputDecls.push_back(OpDecl);
-            InputDeclsAddressOf.push_back(Operand->isReg() &&
-                                          Operand->needAddressOf());
+            InputDeclsAddressOf.push_back(Operand->needAddressOf());
             InputConstraints.push_back(Operand->getConstraint().str());
             AsmStrRewrites.push_back(AsmRewrite(AOK_Input,
                                                 Operand->getStartLoc(),





More information about the llvm-commits mailing list