[llvm-commits] [llvm] r172086 - in /llvm/trunk: include/llvm/Support/SourceMgr.h lib/Support/SourceMgr.cpp

[Jordan Rose]

On Jan 10, 2013, at 11:04 , David Blaikie <dblaikie at gmail.com> wrote:

> On Thu, Jan 10, 2013 at 10:50 AM, Jordan Rose <jordan_rose at apple.com> wrote:
>> Author: jrose
>> Date: Thu Jan 10 12:50:15 2013
>> New Revision: 172086
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=172086&view=rev
>> Log:
>> Add basic fix-its to SMDiagnostic.
>> 
>> Like Clang's FixItHint, SMFixIt represents an insertion, replacement, or
>> removal of source text. One or more fix-its can be emitted as part of
>> a diagnostic, and will be printed below the source range line to show the
>> user how they can fix their code.
>> 
>> Currently, the only client of SMFixIt is clang-tblgen; thus, the tests for
>> this behavior live in clang/test/TableGen/tg-fixits.td. If/when SMFixIt is
>> adopted within LLVM itself, those tests should be moved to the LLVM suite.
> 
> a unit test in LLVM mighte be suitable here - but I realize the
> overhead/hassle of adding one might not be worthwhile/a priority

Hm, good call. I'll see if I have a bit of time in the next few days for that.