[llvm-commits] [PATCH] Enhance TableGen with ranges and fixits

[Jordan Rose]

On Jan 9, 2013, at 17:33 , Jordan Rose <jordan_rose at apple.com> wrote:

> 
> On Jan 9, 2013, at 15:00 , Sean Silva <silvas at purdue.edu> wrote:
> 
>> On Wed, Jan 9, 2013 at 5:27 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>>> And of course, testing actually caught some issues with SMFixIt, so thanks, Sean. Revised patches attached. I've also included the test file I'm using for fixit features, though it has to live up on the Clang side since clang-tblgen is the only user of SMFixIt right now.
>> 
>> Please make sure that all the generated .inc files are identical
>> before and after these patches. (and easy way is to `git init; git add
>> **/*.inc` in the build directory, then apply the patches, rebuild the
>> .inc files and git diff).
> 
> On the LLVM side there are some ordering differences but nothing significant; I assume this comes from TableGen's iteration over maps. (I tried to mostly account for this for the diagnostics by sorting by SMLoc after the fact, but most of the TG emitters don't bother.)

Committed as r172084-6. Thanks for the review, Sean, Jakob, Chris!