[llvm-commits] [lld] r172040 - in /lld/trunk: lib/Driver/LinkerInvocation.cpp lib/ReaderWriter/ELF/ExecutableAtoms.h lib/ReaderWriter/ELF/WriterELF.cpp test/Driver/x86_64-target.test test/elf/Inputs/writersyms.o test/elf/sections.objtxt test/elf/symbols.objtxt

[Sean Silva]

+    bool operator()(const Elf_Phdr* j) const {

You missed this one.

+ if (bssStartAtomIter == abse ||
+     bssEndAtomIter == abse ||
+     underScoreEndAtomIter == abse ||
+     endAtomIter == abse)
+   assert(0 && "Unable to find the absolute atoms that have been
added by lld");
+
+ auto phe = _programHeader->findProgramHeader(
+                                 llvm::ELF::PT_LOAD,
+                                 llvm::ELF::PF_W,
+                                 llvm::ELF::PF_X);
+
+ if (phe == _programHeader->end())
+   assert(0 && "Can't find a data segment in the program header!");

You did not address my review comments about these assert(0)'s.

-- Sean Silva