[llvm-commits] [PATCH] Enhance TableGen with ranges and fixits

Sean Silva silvas at purdue.edu
Wed Jan 9 15:00:48 PST 2013


On Wed, Jan 9, 2013 at 5:27 PM, Jordan Rose <jordan_rose at apple.com> wrote:
> And of course, testing actually caught some issues with SMFixIt, so thanks, Sean. Revised patches attached. I've also included the test file I'm using for fixit features, though it has to live up on the Clang side since clang-tblgen is the only user of SMFixIt right now.

Please make sure that all the generated .inc files are identical
before and after these patches. (and easy way is to `git init; git add
**/*.inc` in the build directory, then apply the patches, rebuild the
.inc files and git diff).

As a side note, would it make sense to have these issues be errors
instead of warnings? Since we strive for a warning free build anyway,
we might as well make it an error so that code violating it just won't
get committed (since it won't build), rather than getting committed
and then someone having to go and fix it up to silence the warning.

-- Sean Silva




More information about the llvm-commits mailing list