[llvm-commits] [llvm] r171983 - /llvm/trunk/lib/CodeGen/MachineInstr.cpp

[Sergei Larin]

Ben,

  David asked the same thing - here is my answer to him...
I wish there would be an easy test here.

Sergei




David,

   Unfortunately no. The bug is exposed in an experimental code, and I am
not sure how to reproduce it on the tip.
The problem is rather obvious though, and clearly a cut/paste kind of thing.

Sergei

---
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


> -----Original Message-----
> From: Benjamin Kramer [mailto:benny.kra at gmail.com]
> Sent: Wednesday, January 09, 2013 12:15 PM
> To: Sergei Larin
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [llvm] r171983 -
> /llvm/trunk/lib/CodeGen/MachineInstr.cpp
> 
> 
> On 09.01.2013, at 18:54, Sergei Larin <slarin at codeaurora.org> wrote:
> 
> > Author: slarin
> > Date: Wed Jan  9 11:54:33 2013
> > New Revision: 171983
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=171983&view=rev
> > Log:
> >
> > Fix a typo in MachineInstr::unbundleFromSucc() method.
> >
> 
> Test case?
> 
> - Ben
> 
> >
> > Modified:
> >    llvm/trunk/lib/CodeGen/MachineInstr.cpp
> >
> > Modified: llvm/trunk/lib/CodeGen/MachineInstr.cpp
> > URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/lib/CodeGen/MachineInstr.cpp?rev=171983&r1=171982&r2
> =171983&view=diff
> >
> =======================================================================
> =======
> > --- llvm/trunk/lib/CodeGen/MachineInstr.cpp (original)
> > +++ llvm/trunk/lib/CodeGen/MachineInstr.cpp Wed Jan  9 11:54:33 2013
> > @@ -897,7 +897,7 @@
> >   assert(isBundledWithSucc() && "MI isn't bundled with its
> successor");
> >   clearFlag(BundledSucc);
> >   MachineBasicBlock::instr_iterator Succ = this;
> > -  --Succ;
> > +  ++Succ;
> >   assert(Succ->isBundledWithPred() && "Inconsistent bundle flags");
> >   Succ->clearFlag(BundledPred);
> > }
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits