[llvm-commits] [PATCH 1/3] Disable -Wuninitialized for gcc

dag at cray.com dag at cray.com
Wed Jan 9 11:12:29 PST 2013


Eric Christopher <echristo at gmail.com> writes:

> Oh painful. That said, probably about the best way of doing that.

Yep.

> One nit:
>
> +if test "$GXX" = "yes"
> +then
>
> is usually done:
>
> if test "x$GXX" = "xyes"; then

I prefer that too, but I followed the style in the rest of configure.ac.

> otherwise OK. Please go ahead and commit all 3 patches in this set in
> the same commit.

Ok, thanks!

                                     -David



More information about the llvm-commits mailing list