[llvm-commits] [llvm] r168931 - in /llvm/trunk: include/llvm/Target/TargetTransformImpl.h include/llvm/TargetTransformInfo.h lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86ISelLowering.h lib/Target/X86/X86TargetMachine.h lib/Transforms/Scalar/LoopIdiomRecognize.cpp test/Transforms/LoopIdiom/popcnt.ll

[Shuxin Yang]

I just try to fix this coding style problem. It seems you already fix it.
Thanks!
>>
>>     Among all the stylistic issues, one issue I'm not quite sure. It
>>     was about enum definition
>>     I copy the style from somewhere else in LLVM, and I check the
>>     coding style std, I don't find
>>     any words about it.  If you find a canonical way to define enum,
>>     please let me know.
>>
>>
>> From the coding standards document[1]:
>> "Unless the enumerators are defined in their own small namespace or 
>> inside a class, enumerators should have a prefix corresponding to the 
>> enum declaration name. For example, enum ValueKind { ... }; may 
>> contain enumerators like VK_Argument, VK_BasicBlock, etc."
>>
>> [1]: 
>> http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130109/b0ffce77/attachment.html>