[llvm-commits] [llvm] r171922 - in /llvm/trunk: include/llvm/IR/Constant.h include/llvm/IR/InstrTypes.h lib/IR/Constants.cpp lib/IR/Instructions.cpp lib/Transforms/InstCombine/InstCombine.h lib/Transforms/InstCombine/InstructionCombining.cpp test/Transforms/InstCombine/fast-math.ll

[Shuxin Yang]

On 1/8/13 4:42 PM, Eric Christopher wrote:
>
>
>     class Constant has a member function call isNegativeZeroValue().
>     I don't feel like to invent a completely different name, so I coin
>     the name "isZeroValue()".
>     When the isZeroValue() and isNegativeZeroValue() stands
>     side-by-side, it ease the reader
>     to guess that isZeroValue() tries to achieve.
>
>     What's your suggestion?
>
>
> Aha. How about improve the comment? With:
>
>     This function will return true iff :
>        - is integer 0, or
>        - is floating point positive or negative 0, i.e. we don't care
>     sign.
>
>
> Maybe this?
>
> -eric
Ok, Thanks

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130108/592d50fb/attachment.html>