[llvm-commits] [PATCH] Enhance TableGen with ranges and fixits

[Chris Lattner]

On Jan 7, 2013, at 1:04 PM, Jakob Stoklund Olesen <jolesen at apple.com> wrote:

> 
> On Jan 7, 2013, at 11:31 AM, Jordan Rose <jordan_rose at apple.com> wrote:
> 
>> Second pass at this. TableGen and SMDiagnostic are being modified to 
>> 
>> (a) Track anonymous definitions.
>> (b) Save source ranges for superclass references (for the fixits).
>> (c) Actually emit fixits (only support here; fixits happening in clang-tblgen)
>> 
>> This should be better than the previous scheme ranges should appear once per superclass per Record, which will not bloat TableGen's memory usage nearly as much as saving ranges on every DefInit. (I would have liked to do it only first the first time a superclass is mentioned, but TableGen represents multiple levels of inheritance by just copying the grandparent into the child as another superclass.) The fixits are a little worse but that's fine.
>> 
>> Again, I'll post the Clang side on cfe-commits soon.
> 
> The TableGen part looks fine to me. I am not familiar with SMDiagnostic.

SMDiagnostic side looks fine to me.

-Chris