[llvm-commits] [patch] Allow >256 ELF relocations

Sean Silva silvas at purdue.edu
Mon Jan 7 16:39:23 PST 2013


+Bigcheese

On Mon, Jan 7, 2013 at 11:19 AM, Renato Golin <renato.golin at linaro.org> wrote:
> Looks good. I don't think there will be any problems, but you may wait for
> someone with more experience in the ELF class to give an opinion.
>
> --renato
>
>
> On 7 January 2013 14:58, Tim Northover <Tim.Northover at arm.com> wrote:
>>
>> Hi all,
>>
>> The ELF64 specification says that 32 bits of the r_info field are used for
>> the
>> relocation type; however the ELF support code currently uses "unsigned
>> char"
>> to store this type. Current targets work because they have <= 256
>> relocations,
>> but AArch64 defines more (or, at least, spreads them out more).
>>
>> This patch switches the types used so that everything works properly.
>>
>> It's part of the change to generic LLVM code that we had to implement
>> while
>> developing the AArch64 backend. These are the changes that no other target
>> exercises, so sending them to the list before would have been a little
>> motive-less, and often untestable.
>>
>> This one is reasonably simple, OK to commit?
>>
>> Cheers.
>>
>> Tim.
>>
>> -- IMPORTANT NOTICE: The contents of this email and any attachments are
>> confidential and may also be privileged. If you are not the intended
>> recipient, please notify the sender immediately and do not disclose the
>> contents to any other person, use it for any purpose, or store or copy the
>> information in any medium.  Thank you.
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list