[llvm-commits] [llvm] r171793 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombine.h lib/Transforms/InstCombine/InstCombineMulDivRem.cpp test/Transforms/InstCombine/fast-math.ll

[Eric Christopher]

>
>
>  +  Value *foldFMulConst(Instruction *FMulOrDiv, ConstantFP *C,
>> +                       Instruction *InsertBefore);
>>
>
>  Formatting.
>
>
> The real code in VI/emacs and the diff sent to the list looks quite
> different from what you pasted here.
> In the code the two "Instruction"s are aligned. (I'm sure there is no
> leading tab, I configure my vi such
> that all tab is converted to space).
>
>
Ah. My email had it how it's pasted. Silly email.


> Are you talking about the alignment issue. Or something else?
>

Nah, that's it.


> I cannot fold the 2nd line to the previous line as it exceeds 80 column.
>
>
Yep.


>  +Value *InstCombiner::foldFMulConst
>> +  (Instruction *FMulOrDiv, ConstantFP *C, Instruction *InsertBefore) {
>>
>
>  Formatting.
>
> The 2nd line is indented by 2 space in the real-code?
> By "formating", do you mean format like this:
>   "Value *class::member (type para1,  /*80-th-column here*/
>                                        type para2);
>
>
Precisely. Go ahead and put as many arguments on the first line as can fit.

Thanks!

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130107/8713c4c6/attachment.html>