[llvm-commits] [llvm] r171793 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombine.h lib/Transforms/InstCombine/InstCombineMulDivRem.cpp test/Transforms/InstCombine/fast-math.ll

[Eric Christopher]

+  Value *foldFMulConst(Instruction *FMulOrDiv, ConstantFP *C,
> +                       Instruction *InsertBefore);
>

Formatting.


> +  if (!I || (I->getOpcode() != Instruction::FMul &&
> +             I->getOpcode() != Instruction::FDiv)) {
> +    return false;
> +  }
> +
>

No need for braces here.


> +Value *InstCombiner::foldFMulConst
> +  (Instruction *FMulOrDiv, ConstantFP *C, Instruction *InsertBefore) {
>

Formatting.


> +        if (C0) {
> +          std::swap(C0, C1); std::swap(Opnd0, Opnd1); Swap = true;
> +        }
> +
>

Was going to say no need for braces here, but I missed the Swap = at the
end of the line, how about putting that on the next line so it's more clear?

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130107/8b146635/attachment.html>