[llvm-commits] [patch] Make AsmPrinter check for Immediate before using

[Renato Golin]

Looks good. Is it easy to reproduce this with a simple test case and
inspect with FileCheck?


On 7 January 2013 15:15, Tim Northover <Tim.Northover at arm.com> wrote:

> Hi all,
>
> Currently, when generating code to print InstAlias<"nop", (HINTi 0)> the
> TableGen backend calls getImm() to check whether the provided immediate is
> correct.
>
> However, in some circumstances, the operand may not actually *be* an
> immediate, it could be an MCExpr for example (contrived here, but realistic
> for more complex instructions). I think TableGen should emit code that
> checks
> whether it *is* an immediate before calling getImm(). This patch implements
> that change.
>
> It's part of the change to generic LLVM code that we had to implement while
> developing the AArch64 backend. These are the changes that no other target
> exercises, so sending them to the list before would have been a little
> motive-less, and often untestable.
>
> This one is reasonably simple, OK to commit?
>
> Cheers.
>
> Tim.
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium.  Thank you.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130107/58e02ffb/attachment.html>