[llvm-commits] [PATCH] Teach the MergeGlobals pass to handle non-default address spaces

[Silviu Baranga]

Thanks! Committed in r171730.

 

Cheers,

Silviu

 

From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: 07 January 2013 11:31
To: Silviu Baranga
Cc: LLVM Commits
Subject: Re: [llvm-commits] [PATCH] Teach the MergeGlobals pass to handle
non-default address spaces

 

Hi Silvio,

 

The change seems sensible, but I'll leave for someone with more knowledge on
globals merge to approve.

 

There are some parts that need 80 columns trimming, though, they were not
the first in that file... Not sure if people care about it that much these
days.

 

+  for (DenseMap<unsigned, SmallVector<GlobalVariable*, 16> >::iterator

+       I = Globals.begin(), E = Globals.end(); I != E; ++I)

 

Possibly moving begin/end out would be better.

 

cheers,

--renato

 

 

On 7 January 2013 10:25, Silviu Baranga <silbar01 at arm.com> wrote:

Hi,

The MergeGlobals pass crashes when trying to handle globals with a
non-default
address space. The attached patch fixes this by only merging globals that
have the same address space and by preserving the address space after the
merge.

Please review!

Thanks,
Silviu
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130107/77b92541/attachment.html>