[llvm-commits] [llvm] r171567 - /llvm/trunk/include/llvm/ADT/DenseMap.h

[Chandler Carruth]

On Fri, Jan 4, 2013 at 6:58 PM, Alex Rosenberg <alexr at leftfield.org> wrote:

> llvm-gcc-4.2 complains about it. The constructor is empty anyway.
>

But this will just regress, and it must happen in other places... Dunno, I
just worry about trying to chase warning cleanliness on an old compiler
that aren't finding bugs... It feels like churn for near-zero gain.

Anyways... back to other stuff.


>
> Sent from my iPad
>
> On Jan 4, 2013, at 4:44 PM, Chandler Carruth <chandlerc at google.com> wrote:
>
> On Fri, Jan 4, 2013 at 4:21 PM, Alex Rosenberg <alexr at leftfield.org>wrote:
>
>> Author: alexr
>> Date: Fri Jan  4 18:21:12 2013
>> New Revision: 171567
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=171567&view=rev
>> Log:
>> Fix warnings from llvm-gcc as seen on darwin10 (10.6).
>>
>
> Is this really worthwhile? Calling the base constructor happens implicitly
> as the standard requires it...
>
>
>>
>> Modified:
>>     llvm/trunk/include/llvm/ADT/DenseMap.h
>>
>> Modified: llvm/trunk/include/llvm/ADT/DenseMap.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseMap.h?rev=171567&r1=171566&r2=171567&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/include/llvm/ADT/DenseMap.h (original)
>> +++ llvm/trunk/include/llvm/ADT/DenseMap.h Fri Jan  4 18:21:12 2013
>> @@ -531,13 +531,13 @@
>>      init(NumInitBuckets);
>>    }
>>
>> -  DenseMap(const DenseMap &other) {
>> +  DenseMap(const DenseMap &other) : BaseT() {
>>      init(0);
>>      copyFrom(other);
>>    }
>>
>>  #if LLVM_HAS_RVALUE_REFERENCES
>> -  DenseMap(DenseMap &&other) {
>> +  DenseMap(DenseMap &&other) : BaseT() {
>>      init(0);
>>      swap(other);
>>    }
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130104/12e93ab6/attachment.html>