[llvm-commits] [llvm] r171158 - in /llvm/trunk/include/llvm: ADT/IntervalMap.h CodeGen/SlotIndexes.h

[Lang Hames]

Oh yeah. +1. Thanks for looking at this.


On Sat, Dec 29, 2012 at 1:13 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:

>
> On Dec 27, 2012, at 3:29 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
>
> > Author: chandlerc
> > Date: Thu Dec 27 05:29:17 2012
> > New Revision: 171158
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=171158&view=rev
> > Log:
> > Provide a common half-open interval map info implementation, and just
> > re-use that for SlotIndexes. This way other users who want half-open
> > semantics can share the implementation.
>
> Hi Chandler,
>
> In retrospect, I think it was a premature abstraction to support closed
> intervals at all. It wasn't quite clear at the time if SlotIndexes would
> work better with closed or half-open intervals. That has been settled now,
> they definitely want half-open intervals.
>
> It would be perfectly fine to have the default IntervalMapInfo
> implementation provide half-open semantics. Then we can also get rid of the
> gross 'a+1' in the adjacent() implementation.
>
> /jakob
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130103/fa7a601c/attachment.html>