[llvm-commits] [PATCH] PR14471: Debug info for static data members (LLVM part)

[Robinson, Paul]

> Few comments:

>
> +  DW_TAG_CXX_static_member = 0x104,     // Tag for C++ static data member.
>
> there is no such tag that I've seen?

This is in enum llvm_dwarf_constants, not enum dwarf_constants.
It's one of several mock tags defined for the metadata interface;
they are not defined by DWARF.  (If the number of real DWARF tags
doubles, we'll have to renumber these to get out of the way.)

> And you don't disassemble to it either.
Not sure what you mean here.

> Also you don't use isStaticData()...
>
> Perhaps there's some part of the patch I'm missing?

See the Clang part of the patch, which does use isStaticDataMember().
--paulr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130103/ea8c1c19/attachment.html>