[llvm-commits] [PATCH] MipsJITInfo.cpp on OpenBSD

[Brad Smith]

On Thu, Jan 03, 2013 at 01:16:16AM +0000, Jovanovic, Petar wrote:
> The patch looks ok to me, and I am fine it gets committed if it resolves a real issue for someone. Is there a real issue behind?

Not building seems like a "real" issue or am I wrong?

> I mean, if you can already patch it locally and compile it, is there a burden of having that as a local patch?

If push comes to shove we can keep this as a local patch but the goal is to make an attempt
to push whatever we can upstream to reduce local patching as much as possible.

> The thing is that patches like this one reduce readability, and the only benefit is that we can still use the old toolchain that does not recognize symbolic names.
> 
> Can you work the other way and update/patch the binutils so it recognizes symbolic register names?

I can't really comment on this. We're using binutils 2.15 at the moment and the plan is
to eventually update to 2.17 but I don't know when that will be and if that will help
at all with this particular issue.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.