[llvm-commits] [llvm] r171306 - /llvm/trunk/lib/Analysis/MemoryBuiltins.cpp

[Nuno Lopes]

I've reverted the patch. Thanks for the heads up!
I forgot that I cannot abuse APInt that much..

Nuno

----- Original Message -----
> It broke +Asserts.
>
> FAIL: LLVM :: Instrumentation/BoundsChecking/simple.ll (3903 of 7048)
> ******************** TEST 'LLVM ::
> Instrumentation/BoundsChecking/simple.ll' FAILED ********************
> Script:
> --
> /home/chapuni/BUILD/cmake-static/Release/bin/./opt <
> /home/chapuni/llvm-project/llvm/test/Instrumentation/BoundsChecking/simple.ll
> -bounds-checking -S |
> /home/chapuni/BUILD/cmake-static/Release/bin/./FileCheck
> /home/chapuni/llvm-project/llvm/test/Instrumentation/BoundsChecking/simple.ll
> --
> Exit Code: 2
> Command Output (stderr):
> --
> opt: /home/chapuni/llvm-project/llvm/include/llvm/ADT/APInt.h:888:
> bool llvm::APInt::operator==(const llvm::APInt&) const: Assertion
> `BitWidth == RHS.BitWidth && "Comparison requires equal bit widths"'
> failed.
>
> 2013/1/1 Nuno Lopes <nunoplopes at sapo.pt>:
>> Author: nlopes
>> Date: Mon Dec 31 11:25:24 2012
>> New Revision: 171306
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=171306&view=rev
>> Log:
>> minor code simplification
>>
>> Modified:
>>     llvm/trunk/lib/Analysis/MemoryBuiltins.cpp
>>
>> Modified: llvm/trunk/lib/Analysis/MemoryBuiltins.cpp
>> URL: 
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/MemoryBuiltins.cpp?rev=171306&r1=171305&r2=171306&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Analysis/MemoryBuiltins.cpp (original)
>> +++ llvm/trunk/lib/Analysis/MemoryBuiltins.cpp Mon Dec 31 11:25:24 2012
>> @@ -562,7 +562,7 @@
>>  SizeOffsetType ObjectSizeOffsetVisitor::visitSelectInst(SelectInst &I) {
>>    SizeOffsetType TrueSide  = compute(I.getTrueValue());
>>    SizeOffsetType FalseSide = compute(I.getFalseValue());
>> -  if (bothKnown(TrueSide) && bothKnown(FalseSide) && TrueSide == 
>> FalseSide)
>> +  if (TrueSide == FalseSide)
>>      return TrueSide;
>>    return unknown();
>>  }
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits