[llvm-commits] [PATCH 2/3] Make llvm-readobj also output all sections in the object file.

Sean Silva silvas at purdue.edu
Fri Dec 28 11:50:23 PST 2012


On Fri, Dec 28, 2012 at 10:17 AM, Sami Liedes <sami.liedes at iki.fi> wrote:
> I could submit a patch to lower-case the current function names too,
> but I somehow got the feeling from reading the LLVM Coding Standards
> that such patches are generally despised.

Such patches are usually fine as long as they are relatively localized
(i.e. don't require renames across the whole project) and are just a
precursor to another change (just look at how many "fix whitespace"
commits we have). However, if you don't have commit access, then the
overhead of such a patch is pretty large (whereas a committer could
just immediately commit it and move on), so I wouldn't bother in your
case and just follow the golden rule
<http://llvm.org/docs/CodingStandards.html#golden-rule>.

-- Sean Silva



More information about the llvm-commits mailing list