[llvm-commits] [PATCH 2/3] Make llvm-readobj also output all sections in the object file.

[Rafael Espíndola]

On 27 December 2012 18:20, Sami Liedes <sami.liedes at iki.fi> wrote:
> Make llvm-readobj also output all sections in the object.
>
> This can be used to write a test for PR14723.

Please start functions with a lower case. Can you make checkError just
check the error_code instead of calling the function too? That way we
would have

StringRef Name;
CheckError(SymbolRef::getName(Name), "SymbolRef.getName() failed");

Which is a bit more verbose but easier to read IMHO than

StringRef Name =
  CheckError(Sym, &SymbolRef::getName, "SymbolRef.getName() failed");

Thanks,
Rafael