[llvm-commits] [PATCH] Use ASanContext to store context- and data layout specific types and values shared between ASan instrumentation passes.

[Chandler Carruth]

  It may just be me, but I find this to be a net readability loss.

  None of the code it simplifies is really simplified that much. Much of the code is actually made more complex (C->IntptrTy is more gross than just IntptrTy...), and it introduces a really unfortunate overloading of my mental model: is 'C' the LLVMContext or ASanContext? I have no idea. Also, I expect it to be surprising that ASanContext is per-module, where the LLVMContext isn't...

http://llvm-reviews.chandlerc.com/D250